rdhabalia commented on a change in pull request #1223: Add a `internalConfiguration` admin restful endpoint for query internal configuration URL: https://github.com/apache/incubator-pulsar/pull/1223#discussion_r168568376
########## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/InternalConfiguration.java ########## @@ -0,0 +1,50 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.broker.admin; + +import io.swagger.annotations.Api; +import io.swagger.annotations.ApiOperation; +import io.swagger.annotations.ApiResponse; +import io.swagger.annotations.ApiResponses; +import javax.ws.rs.GET; +import javax.ws.rs.Path; +import javax.ws.rs.Produces; +import javax.ws.rs.core.MediaType; +import org.apache.bookkeeper.conf.ClientConfiguration; +import org.apache.pulsar.common.conf.InternalConfigurationData; + +@Path("/internal-configuration") +@Api(value = "/internal-configuration", description = "InternalConfiguration admin apis", tags = "internal-configuration") +@Produces(MediaType.APPLICATION_JSON) +public class InternalConfiguration extends AdminResource { + + @GET + @ApiOperation(value = "Get the internal configuration data", response = InternalConfigurationData.class) + @ApiResponses(value = { + @ApiResponse(code = 403, message = "Don't have admin permission") Review comment: yes, that's correct. I meant `code = 403, message = "Don't have admin permission"` if we think zk-endpoint information should not expose to user and should be accessed by only admin then we can add validation `AdminResource::validateSuperUserAccess()` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
