rdhabalia commented on a change in pull request #1223: Add a
`internalConfiguration` admin restful endpoint for query internal configuration
URL: https://github.com/apache/incubator-pulsar/pull/1223#discussion_r168576091
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/PulsarAdmin.java
##########
@@ -154,6 +156,7 @@ public PulsarAdmin(URL serviceUrl, ClientConfiguration
pulsarConfig) throws Puls
WebTarget root = client.target(serviceUrl.toString());
web = root.path("/admin");
+ this.internalConfiguration = new InternalConfigurationImpl(web, auth);
Review comment:
Ok..sure.. I am not strongly against of having separate resource.
Actually brokers already has `DynamicConfiguration` endpoint as well and
internal-config also looks like config which is configured in broker rather a
config/policies persisted in zk. So, felt to be part of brokers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
