merlimat commented on issue #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-391173087 > Rename MessageBuilder to a ProducerMessage since it is no longer implements a builder pattern? Yes, I didn't want to call it `Message` or `MessageOptions`, `ProducerMessage` sounds good. > It may be useful to include the message in SendAsync error callback in order to correlate the error to the message. Yes, mostly in C++ or Java you attach that by adding the value on the lambda. Changed it here > There should be control over logging, either turning it off or provide an interface to wrap it somehow so the structure can be controlled. Good point, the log4cxx based logger was a bit overkill and not well integrated. Replaced now and allow to set logger function callback. > I noticed I could not create a binary that statically linked libpulsar. This could be my environment, but this was the output: This I think is more related to cgo and MacOS. I have the same but it was working on linux.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
