TheR1sing3un commented on code in PR #6122: URL: https://github.com/apache/rocketmq/pull/6122#discussion_r1111425321
########## store/src/main/java/org/apache/rocketmq/store/ha/DefaultHAConnection.java: ########## @@ -31,6 +31,22 @@ import org.apache.rocketmq.store.SelectMappedBufferResult; public class DefaultHAConnection implements HAConnection { + + /** + * Transfer Header buffer size. Schema: physic offset and body size. Format: + * + * <pre> + * ┌───────────────────────┬───────────────────────┬───────────────────────┐ + * │ physicOffset │ bodySize │ + * │ (8bytes) │ (4bytes) │ + * ├───────────────────────┴───────────────────────┴───────────────────────┤ + * │ │ + * │ Transfer Header │ + * </pre> + * <p> + */ Review Comment: > how about consolidation form > > ``` > /** > * Transfer Header buffer size. Schema: physic offset and body size. Format: > * > * <pre> > * ┌───────────────────────────────────────────────┬───────────────────────┐ > * │ physicOffset │ bodySize │ > * │ (8bytes) │ (4bytes) │ > * ├───────────────────────────────────────────────┴───────────────────────┤ > * │ │ > * │ Transfer Header │ > * </pre> > * <p> > */ > ``` sounds good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org