aaron-ai commented on code in PR #642: URL: https://github.com/apache/rocketmq-clients/pull/642#discussion_r1411673524
########## cpp/source/rocketmq/ProducerImpl.cpp: ########## @@ -575,9 +576,22 @@ void ProducerImpl::onOrphanedTransactionalMessage(MessageConstSharedPtr message) } } -void ProducerImpl::topicsOfInterest(std::vector<std::string> topics) { +void ProducerImpl::topicsOfInterest(std::vector<std::string> &topics) { absl::MutexLock lk(&topics_mtx_); - topics_.swap(topics); + for (auto& topic : topics_) { Review Comment: Does `ProducerImpl#topicOfInterest` simply retrieve a copy of the topics for sending messages? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org