drivebyer opened a new pull request, #211:
URL: https://github.com/apache/rocketmq-operator/pull/211

   ## What is the purpose of the change
   
   Add e2e test workflow on pr request
   
   ## Brief changelog
   
   Add e2e test workflow on pr request
   
   ## Verifying this change
   
   See the pr test.
   
   **Please go through this checklist to help us incorporate your contribution 
quickly and easily.**
   
   Notice: `It would be helpful if you could finish the following checklist 
(the last one is not necessary) before request the community to review your PR`.
   
   - [ ] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq-operator/issues) filed for the change 
(usually before you start working on it). Trivial changes like typos do not 
require a Github issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue. 
   - [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [ ] Check RBAC rights for Kubernetes roles.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. 
   - [ ] Run `make docker-build` to build docker image for operator, try your 
changes from Pod inside your Kubernetes cluster, **not just locally**. Also 
provide screenshots to show that the RocketMQ cluster is healthy after the 
changes. 
   - [ ] Before committing your changes, remember to run `make manifests` to 
make sure the CRD files are updated. 
   - [ ] Update documentation if necessary.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to