cserwen commented on code in PR #8027:
URL: https://github.com/apache/rocketmq/pull/8027#discussion_r1593806191
##########
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java:
##########
@@ -2007,6 +2007,7 @@ public TopicRouteData
getTopicRouteInfoFromNameServer(final String topic, final
case ResponseCode.TOPIC_NOT_EXIST: {
if (allowTopicNotExist) {
log.warn("get Topic [{}] RouteInfoFromNameServer is not
exist value", topic);
+ return null;
Review Comment:
This may cause sime npe, maybe need to check, such as
https://github.com/apache/rocketmq/blob/ad027560780c2af801e4bcb447d85bf0df62071a/proxy/src/main/java/org/apache/rocketmq/proxy/service/admin/DefaultAdminService.java#L60-L85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
