RongtongJin commented on code in PR #9549:
URL: https://github.com/apache/rocketmq/pull/9549#discussion_r2362097066
##########
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java:
##########
@@ -1834,6 +1853,16 @@ public void run() {
}
}
}, 10, 5, TimeUnit.SECONDS);
+
+ if (this.routeEventService != null && this.topicConfigManager != null)
{
+ Set<String> topics =
this.topicConfigManager.getTopicConfigTable().keySet();
+ try {
+ this.routeEventService.publishEvent(RouteEventType.START,
topics);
+ LOG.info("[START]: publish {}", topics);
+ } catch (Exception e) {
+ LOG.error("Failed to publish route change event for topic:
{}", topics, e);
+ }
+ }
Review Comment:
这段放在先放在
if (!isIsolated &&
!this.messageStoreConfig.isEnableDLegerCommitLog() &&
!this.messageStoreConfig.isDuplicationEnable()) {
changeSpecialServiceStatus(this.brokerConfig.getBrokerId() ==
MixAll.MASTER_ID);
this.registerBrokerAll(true, false, true);
}
里吧，也就是broker启动后向namesrv启动注册之后
##########
broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java:
##########
@@ -349,6 +363,8 @@ public TopicConfig createTopicIfAbsent(TopicConfig
topicConfig, boolean register
}
if (createNew && register) {
registerBrokerData(topicConfig);
+
+ publishTopicChangeEvent(topicConfig.getTopicName());
Review Comment:
这里可以都放到registerBrokerData方法里
##########
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java:
##########
@@ -1834,6 +1853,16 @@ public void run() {
}
}
}, 10, 5, TimeUnit.SECONDS);
+
+ if (this.routeEventService != null && this.topicConfigManager != null)
{
+ Set<String> topics =
this.topicConfigManager.getTopicConfigTable().keySet();
+ try {
+ this.routeEventService.publishEvent(RouteEventType.START,
topics);
+ LOG.info("[START]: publish {}", topics);
Review Comment:
publish event
##########
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java:
##########
@@ -1395,6 +1404,16 @@ protected void shutdownBasicService() {
this.unregisterBrokerAll();
+ if (this.routeEventService != null && this.topicConfigManager != null)
{
+ Set<String> topics =
this.topicConfigManager.getTopicConfigTable().keySet();
+ try {
+ this.routeEventService.publishEvent(RouteEventType.SHUTDOWN,
topics);
+ LOG.info("[SHUTDOWN AFTER unregisterBrokerAll]: publish {}",
topics);
Review Comment:
有个小问题，比如一开始启动enableRouteChangeNotification是true，运行时通过命令修改为false，那关闭的时候（this.routeEventService
!= nul）仍然会打印无效日志
##########
broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java:
##########
@@ -601,11 +621,23 @@ public void deleteTopicConfig(final String topic) {
log.info("delete topic config OK, topic: {}", old);
updateDataVersion();
this.persist();
+
+ publishTopicChangeEvent(topic);
Review Comment:
deleteTopic放在这里不合适，可以看到org.apache.rocketmq.broker.slave.SlaveSynchronize#syncTopicConfig
主备同步topic元数据也会调用该方法，此时会一直发事件
##########
broker/src/main/java/org/apache/rocketmq/broker/route/RouteEventService.java:
##########
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.broker.route;
+
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+import org.apache.rocketmq.broker.BrokerController;
+import org.apache.rocketmq.common.constant.LoggerName;
+import org.apache.rocketmq.common.message.MessageExtBrokerInner;
+import org.apache.rocketmq.common.topic.TopicValidator;
+import org.apache.rocketmq.logging.org.slf4j.Logger;
+import org.apache.rocketmq.logging.org.slf4j.LoggerFactory;
+import org.apache.rocketmq.store.PutMessageResult;
+
+import com.alibaba.fastjson2.JSON;
+
+public class RouteEventService {
+ private static final Logger LOG =
LoggerFactory.getLogger(LoggerName.BROKER_LOGGER_NAME);
+ private final BrokerController brokerController;
+ private static final int MAX_TOPICS_PER_EVENT = 100;
Review Comment:
默认批次太小了，可以设置为 5000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
