RongtongJin commented on code in PR #9549:
URL: https://github.com/apache/rocketmq/pull/9549#discussion_r2366557337
##########
broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java:
##########
@@ -616,23 +608,29 @@ public boolean isOrderTopic(final String topic) {
}
public void deleteTopicConfig(final String topic) {
+ deleteTopicConfig(topic, true);
+ }
+
+ public void deleteTopicConfig(final String topic, boolean publishEvent) {
Review Comment:
publishTopicChangeEvent可以收敛到RouteEventService,registerBrokerData直接调用this.brokerController.getRouteEventService(),deleteTopic暂时不改(不需要publishTopicChangeEvent),因为当前发现deleteTopic也不会向Namesrv通知路由更新,所以也就不需要去通知Proxy路由更新
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]