lizhimins commented on code in PR #95:
URL: https://github.com/apache/rocketmq-apis/pull/95#discussion_r2418342374
##########
apache/rocketmq/v2/service.proto:
##########
@@ -311,6 +320,21 @@ message RecallMessageResponse {
string message_id = 2;
}
+message SyncLiteSubscriptionRequest {
+ LiteSubscriptionAction action = 1;
+ // bindTopic for lite push consumer
+ Resource topic = 2;
+ // consumer group
+ Resource group = 3;
+ // lite subscription set of lite topics
+ repeated string liteTopicSet = 4;
Review Comment:
use "_"
##########
apache/rocketmq/v2/definition.proto:
##########
@@ -548,6 +562,24 @@ message Subscription {
// Long-polling timeout for `ReceiveMessageRequest`, which is essential for
// push consumer.
optional google.protobuf.Duration long_polling_timeout = 5;
+
+ // Only lite push consumer
+ // client-side lite subscription quota limit
+ optional int32 lite_subscription_quota = 6;
+ // Only lite push consumer
+ // Maximum length limit for lite topic
+ optional int32 max_lite_topic_size = 7;
Review Comment:
注意空行，注意名称的对齐，应该是 lite_topic_max_size
##########
apache/rocketmq/v2/service.proto:
##########
@@ -193,6 +195,10 @@ message RecoverOrphanedTransactionCommand {
string transaction_id = 2;
}
+message NotifyUnsubscribeLiteCommand {
+ string liteTopic = 1;
Review Comment:
lite_topic
##########
apache/rocketmq/v2/definition.proto:
##########
@@ -548,6 +562,24 @@ message Subscription {
// Long-polling timeout for `ReceiveMessageRequest`, which is essential for
// push consumer.
optional google.protobuf.Duration long_polling_timeout = 5;
+
+ // Only lite push consumer
+ // client-side lite subscription quota limit
+ optional int32 lite_subscription_quota = 6;
+ // Only lite push consumer
+ // Maximum length limit for lite topic
+ optional int32 max_lite_topic_size = 7;
+}
+
+enum LiteSubscriptionAction {
Review Comment:
一般是
enum class LiteSubscriptionAction {
PartialAdd = 0,
PartialRemove = 1,
CompleteAdd = 2,
CompleteRemove = 3
};
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
