fuyou001 commented on PR #10448: URL: https://github.com/apache/rocketmq/pull/10448#issuecomment-4790020707
For `deleteTopicList`, I suggest reusing the existing single-topic delete path instead of maintaining a separate cleanup sequence. The batch handler can iterate over the requested topics, call `deleteTopic(...)` for each one, and guard the loop with a `RateLimiter` such as `RateLimiter.create(10.0)` so it deletes at most 10 topics per second. That keeps the batch API aligned with the current single-delete semantics and avoids a large batch request creating a sudden cleanup burst on the broker. It would also be good to add a regression test covering the throttled batch path and invalid-entry handling before the loop starts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
