wang-jiahua commented on PR #10539: URL: https://github.com/apache/rocketmq/pull/10539#issuecomment-4842257661
Thanks for the review @RongtongJin! **1. Tests added** — Added `RemotingMetricsManagerTest` with 7 test cases covering: - Same args return cached instance (cache hit) - Different `requestCode` / `responseCode` / `isLongPolling` / `result` each produce distinct cached Attributes - Unknown result values (not in the known set) use the non-cached path (returns new instance each time) - All 4 known result types (SUCCESS, ONEWAY, WRITE_CHANNEL_FAILED, CANCELED) are properly cached **2. PR description updated** — Removed the `processTimerElapsedMs` mention from the description. This PR only adds the Attributes cache and the `isDebugEnabled()` guard. The timing change is not part of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
