wang-jiahua commented on PR #10564: URL: https://github.com/apache/rocketmq/pull/10564#issuecomment-4852344176
Thanks for the review @qianye1001! I understand your perspective — using the same producer group for different business topics is not the recommended practice. However, the current behavior is still problematic because: 1. The check-back request is sent to an arbitrary producer that has no knowledge of the transaction, causing it to return UNKNOW. This is not a graceful degradation — it can lead to incorrect transaction commit/rollback. 2. This PR does not change the group abstraction. It only ensures that when a check-back is needed, the broker prefers the original producer (who knows the transaction state). If that producer is offline, it falls back to round-robin (current behavior). 3. The fix is backward compatible — old producers without the clientId property work exactly as before. Would you consider this an acceptable safety improvement, or should I close the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
