wang-jiahua commented on code in PR #10564:
URL: https://github.com/apache/rocketmq/pull/10564#discussion_r3510579667
##########
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java:
##########
@@ -1444,6 +1445,7 @@ public TransactionSendResult
sendMessageInTransaction(final Message msg,
SendResult sendResult = null;
MessageAccessor.putProperty(msg,
MessageConst.PROPERTY_TRANSACTION_PREPARED, "true");
MessageAccessor.putProperty(msg, MessageConst.PROPERTY_PRODUCER_GROUP,
this.defaultMQProducer.getProducerGroup());
+ MessageAccessor.putProperty(msg,
MessageConst.PROPERTY_TRANSACTION_PRODUCER_CLIENT_ID,
this.mQClientFactory.getClientId());
Review Comment:
Good catch. Fixed in the latest commit — added
`MessageAccessor.clearProperty(msgInner,
MessageConst.PROPERTY_TRANSACTION_PRODUCER_CLIENT_ID)` in
`EndTransactionProcessor` alongside the existing
`PROPERTY_TRANSACTION_PREPARED` clear, so the internal routing hint is stripped
from the final committed message and not visible to consumers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
