itxaiohanglover commented on PR #10638: URL: https://github.com/apache/rocketmq/pull/10638#issuecomment-5029969388
Nice minimal fix. One question for scope confirmation: does the same `--add-opens java.base/java.lang=ALL-UNNAMED` need to apply to the broker/proxy start paths, or is the reflective access into `java.lang` specific to the controller path here? A one-line note in the PR body on scope would help reviewers confirm this also fully closes the duplicate #10170. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
