123123213weqw commented on PR #10638: URL: https://github.com/apache/rocketmq/pull/10638#issuecomment-5029989166
@itxaiohanglover good question — I should have called this out in the body. The reflective access is **specific to the controller path**: - Hessian is used in exactly one place in the whole tree: `controller/.../ReplicasInfoManager.java` (`grep -rln com.caucho --include='*.java'` returns only that file). - `broker` starts via `runbroker.sh`, doesn't touch Hessian → no change needed there. - `proxy` starts via `runserver.sh` and so inherits this `--add-opens`, but doesn't actually use Hessian either. The extra flag is a no-op for the proxy on JDK 9+ (the JVM silently ignores opens for packages the process never reflects into), so it's safe to share. So the scope of this PR is "fix controller startup on JDK 17 via the shared `runserver.sh`"; it doesn't claim to fix a Hessian issue on broker/proxy because there isn't one. The duplicate #10170 reports the exact same `SerializerFactory.<clinit>` failure and is fully closed by this change. I'll add a one-line scope note to the PR body to make that explicit for future readers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
