lizhimins commented on PR #455:
URL:
https://github.com/apache/rocketmq-dashboard/pull/455#issuecomment-5045280610
Closing as superseded: the common foundation module (unified Result,
BaseEntity, enums, BusinessException, GlobalExceptionHandler, Cors/Web config)
is already present on the rocketmq-studio branch, introduced by commit 49bc4419
("feat: implement backend common module and auth"). The branch's
GlobalExceptionHandler is also a superset of this PR (it additionally handles
PrometheusException, MethodArgumentNotValidException, and
HttpMessageNotReadableException from #432), so merging would regress it. Thanks
for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
