Aias00 opened a new pull request, #563:
URL: https://github.com/apache/rocketmq-dashboard/pull/563

   ## Summary
   - reject blank PromQL and step values in the Prometheus metrics source
   - reject non-positive query start/end values before calling Prometheus
   - add source-level regression coverage for invalid metric query input
   
   ## Validation
   - 
`JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home
 mvn -q -Dtest=PrometheusMetricsSourceTest test`
   - 
`JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home
 mvn -q test` (295 tests, 0 failures, 0 errors)
   - `git diff --check`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to