chunhai1127 opened a new pull request, #670:
URL: https://github.com/apache/rocketmq-dashboard/pull/670
## What is the purpose of the change
Fixes #669
The Topic page shows an empty table when connected to a 4.x cluster (or any
cluster whose topics report `UNSPECIFIED` message type), even though
`/topic/list.queryTopicType` returns the full data.
Root cause: in `frontend-new/src/pages/Topic/topic.jsx`, `rmqVersion` is
hardcoded to `true` and `setRmqVersion` is never called, so the `!rmqVersion &&
filterNormal && type.includes("UNSPECIFIED")` fallback branch in `filterByType`
is dead code. With only the `NORMAL` checkbox ticked by default, all topics
with `UNSPECIFIED` message type are filtered out and the page renders nothing.
## Brief changelog
Treat `UNSPECIFIED` as `NORMAL` in `filterByType` of
`frontend-new/src/pages/Topic/topic.jsx`, so the default NORMAL filter also
matches topics without a message type attribute (4.x clusters).
## Verifying this change
- `cd frontend-new && npm install && npm run build` passes (CRA production
build succeeds, no new eslint warnings).
- Manually verified against a 4.x cluster deployed with
`apacherocketmq/rocketmq-dashboard:2.1.0`: before the fix the topic list is
empty until the `UNSPECIFIED` checkbox is ticked; after the fix all topics
render with the default filter.
Follow this checklist to help us incorporate your contribution quickly and
easily. Notice, `it would be helpful if you could finish the following 5
checklist(the last one is not necessary)before request the community to review
your PR`.
- [x] Make sure there is a [Github
issue](https://github.com/apache/rocketmq-dashboard/issues/669) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a Github issue. Your pull request should address just this issue,
without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException
when host config not exist`. Each commit in the pull request should have a
meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic
correction, more mock a little better when cross module dependency exist. If
the new feature or significant change is committed, please remember to add
integration-test in [test
module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile
failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual
Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
