chunhai1127 commented on PR #670: URL: https://github.com/apache/rocketmq-dashboard/pull/670#issuecomment-5213640056
Hi @lizhimins, thanks for the pointer. I looked into the `rocketmq-studio` branch and confirmed the UNSPECIFIED filtering issue does **not** exist in the new studio UI — it is already handled at the backend level: 1. **Frontend** (`web/src/pages/instance/topic.tsx`): the type filter is now a dropdown (`typeFilter`, default `''` = "All"). Since the default does not filter, topics are never hidden by default — the original "empty list" bug cannot occur. 2. **Backend enum** (`server/.../model/TopicType.java`): the `TopicType` enum no longer contains `UNSPECIFIED` (only `NORMAL`, `FIFO`, `DELAY`, `TRANSACTION`, `LITE`). 3. **Backend parsing** (`server/.../provider/apache/RocketMQMetadataProvider.java#parseTopicType`): blank/unknown type values (including the old `UNSPECIFIED`) fall back to `TopicType.NORMAL`, so 4.x cluster topics are correctly classified and still show up when the "Normal" filter is selected. Given the above, there is no need to re-submit against `web/src/pages/instance/topic.tsx`. Closing this PR was the right call. Thanks again for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
