lizhimins commented on PR #663: URL: https://github.com/apache/rocketmq-dashboard/pull/663#issuecomment-5140752952
Closing: prefixing the aria-label with the hardcoded Chinese string "状态：" conflicts with the localization approach merged in #627, where StatusBadge accessible names follow the active locale — English users would hear a Chinese prefix. If a role prefix is desirable, it should go through the i18n layer (t(...)) instead of a literal. Thanks for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
