Aias00 opened a new issue, #844:
URL: https://github.com/apache/rocketmq-dashboard/issues/844

   ### Problem
   
   The Studio data source create/update endpoints use `@Valid @RequestBody 
DataSourceVO`, but a JSON literal `null` request body can still bind as a null 
object. The controller then forwards that null value to 
`SettingsService.createDataSource` or `SettingsService.updateDataSource`.
   
   `SettingsService.createDataSource` currently logs `dataSource.getName()` 
before any null guard, so this path can fail with an internal 
NullPointerException instead of a structured 400 response. The update path has 
the same null-input contract gap before key normalization.
   
   ### Expected behavior
   
   Data source write APIs should reject missing/null bodies with a clear 400 
response and should not invoke repository operations.
   
   ### Suggested fix
   
   Add controller/service-level null guards for create/update data source 
requests and add tests for JSON `null` request bodies plus direct service 
invocation.
   
   ### Scope
   
   RocketMQ Studio / METRICS-01 data source management API validation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to