Aias00 opened a new pull request, #921: URL: https://github.com/apache/rocketmq-dashboard/pull/921
### What is changed This PR fixes #920 by making mock instance deletion reject missing ids. ### Why The API-backed instance service rejects missing instance ids, but the web mock service silently returned success when no record matched. That can make the Instance page show a successful delete for a stale or invalid row. ### How it is fixed - Throw `Instance not found: <id>` when mock deletion cannot find the requested id. - Add regression coverage that a failed delete leaves the stored mock instance list unchanged. ### Verification - `npm test -- --run src/services/instanceService.test.ts` - `git diff --check` - `npm run lint -- src/services/instanceService.ts src/services/instanceService.test.ts` (passes with existing fast-refresh warnings in unrelated files) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
