123123213weqw opened a new pull request, #1042:
URL: https://github.com/apache/rocketmq-dashboard/pull/1042
## What is the purpose of the change
`RocketMQDashboardProvider` reads the live NameServer topology without
guarding the fields that come back from the wire.
`clusterInfo.getClusterAddrTable()` / `getBrokerAddrTable()` are dereferenced
directly, and `brokerData.getBrokerAddrs().get(0L)` has no null check. Because
the whole computation sits inside one outer `try`, a single NPE on a partial
payload falls into `catch (Exception e) { return emptyDashboard(); }` and
**every number on the dashboard is silently zeroed** — cluster, broker, topic
and group counts plus TPS all become 0, masking the data that could have been
collected.
Sibling providers already defend these exact fields (`RealClusterProvider`
defaults the maps to `Map.of()`, `RocketMQClusterProvider` null-checks
`getBrokerAddrs()`); `RocketMQDashboardProvider` was the remaining one that did
not.
## Brief changelog
- `RocketMQDashboardProvider.getDashboardData()`:
- Treat a null `clusterAddrTable` / `brokerAddrTable` as empty (no NPE, no
dashboard zeroing).
- Skip brokers with a null `getBrokerAddrs()` when collecting master
addresses and when building per-cluster overviews.
- Return an empty dashboard early when the NameServer returns no topology
at all.
## Verifying this change
- `mvn test -Dtest=RocketMQDashboardProviderTest` — 3 tests pass (1 existing
+ 2 new: null topology tables, broker without address table).
- Full unit suite verified via CI.
Follow this checklist to help us incorporate your contribution quickly and
easily. Notice, `it would be helpful if you could finish the following 5
checklist(the last one is not necessary)before request the community to review
your PR`.
- [x] Make sure there is a [Github
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually
before you start working on it). Trivial changes like typos do not require a
Github issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException
when host config not exist`. Each commit in the pull request should have a
meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic
correction, more mock a little better when cross module dependency exist. If
the new feature or significant change is committed, please remember to add
integration-test in [test
module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile
failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual
Contributor License Agreement](http://www.apache.org/licenses/#clas).
Closes #1040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
