RockteMQ-AI commented on issue #1186: URL: https://github.com/apache/rocketmq-dashboard/issues/1186#issuecomment-5216269553
**Issue Evaluation** Category: `bug` | Status: **Confirmed** This is a valid bug in `ClusterService.updateClusterConfig`. Persisting configuration when no addressable Broker target exists creates a false sense of success — the configuration is stored but never actually applied to any Broker. **Root Cause:** The method does not validate that at least one Broker has a reachable address before proceeding with the update and persistence. **Expected Fix:** 1. Check if the Broker list is empty or all Brokers have empty addresses before proceeding. 2. Return an error / reject the update when no addressable target exists. 3. Do not persist the configuration in this case. 4. Preserve per-Broker partial failure reporting when at least one addressable target exists. 5. Add focused service tests for the empty/unreachable Broker scenarios. **Impact:** Medium — silent configuration loss when Brokers are unreachable. **Severity:** Medium — data consistency risk in configuration management. --- *Automated evaluation by @RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
