tju-yxq opened a new pull request, #1399: URL: https://github.com/apache/rocketmq-dashboard/pull/1399
## What is the purpose of the change Fixes #1392 `updateTopic()` was only persisting `writeQueues`, `readQueues`, `perm`, and `updatedAt` to the database, but NOT `topicType` or `remark`. This meant that when a user updated a topic's type or remark, the broker config was updated correctly but the Studio database retained the old values, causing the UI to display stale information. ## Brief changelog - **`RocketMQAdminClientImpl.java`**: Added `topicType` and `remark` persistence in the `updateTopic` method's DB update block, matching the behavior already present in `createTopic`. - **`RocketMQAdminClientImpl.java`**: Removed dead variable `fullTopic` in `sendMessage` that was computed but never used. ## Verifying this change 1. Create a topic with type `NORMAL` and remark `"original"`. 2. Update the topic with a new remark `"updated"`. 3. Refresh the topic list - the remark should now show `"updated"`. 4. Before this fix, the remark would still show `"original"`. - [x] Make sure there is a Github issue filed for the change. - [x] Format the pull request title like `[ISSUE #1392] ...`. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction. - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
