tju-yxq commented on PR #1884: URL: https://github.com/apache/rocketmq-dashboard/pull/1884#issuecomment-5270750892
Follow-up: I opened #2043 as a fuller replacement/follow-up for this issue. Reason: sorting the records already collected by queue scan order is useful, but it does not address the limit edge case where an earlier scanned queue fills the default topic-query limit before later queues are scanned. In that case, newer messages from later queues can still be omitted entirely. #2043 keeps a bounded set of the newest records while scanning all returned queues, then returns the candidates sorted newest-first. It also adds mocked tests for both cross-queue ordering and the earlier-queue-fills-limit edge case. Verification for #2043: ```bash cd server mvn -DskipTests=false "-Dtest=RocketMQMessageProviderTest#queryByTopicSortsMessagesAcrossQueuesNewestFirst+queryByTopicKeepsNewestMessagesWhenEarlierQueuesFillTheDefaultLimit+queryByTopicStopsWhenPullOffsetDoesNotAdvance" test ``` Result: `BUILD SUCCESS`; `Tests run: 3, Failures: 0, Errors: 0, Skipped: 0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
