RockteMQ-AI commented on issue #2047: URL: https://github.com/apache/rocketmq-dashboard/issues/2047#issuecomment-5275838301
**Issue Evaluation** Category: `enhancement` | Status: **Evaluated** **Feasibility:** Feasible **Scope:** ACL module (backend `provider/tencent` + frontend ACL page), DTOs (`DeleteRequestDTO`), API routing (`/api/acl/users`, `/api/acl/rules`) **Compatibility:** Non-breaking — adds `instanceId` routing as optional parameter; existing APACHE/ALIYUN vendors continue using local MySQL store unchanged. This is a well-structured feature request that maps Tencent TDMQ RocketMQ 5.x role management (`DescribeRoleList`, `CreateRole`, `ModifyRole`, `DeleteRole`) onto the dashboard ACL user/rule models. The proposal correctly: 1. Treats each cloud role as a cluster-wide ACL rule (principal=role, resource=`*`, actions from PermRead/PermWrite) 2. Routes by `instanceId` so only TENCENT instances hit the cloud API 3. Surfaces `stateSource=TENCENT_ROLE` for capability negotiation The referenced Trocket SDK APIs (v20230308) and the testing evidence (68 ACL unit tests, frontend build, manual verification) suggest this is ready for implementation. **Recommendation:** This can proceed as a PR. Ensure the `instanceId` threading through DTOs is covered by integration tests against a mock Tencent API endpoint. --- *Automated evaluation by github-manager* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
