btlqql opened a new pull request, #2061:
URL: https://github.com/apache/rocketmq-dashboard/pull/2061

   ## What is the purpose of the change
   
   Fix #2004.
   
   AlertService.acknowledgeAlert reads a system alert and then calls 
AlertRepository.saveAlert. The MyBatis repository implements saveAlert as an 
upsert: it selects by ID and inserts when the row is absent. If 
clearAcknowledged deletes the alert after the acknowledgement request read it 
but before saveAlert runs, the acknowledgement path re-inserts the deleted 
alert.
   
   ## Brief changelog
   
   - AlertRepository: add replaceAlert that updates an existing alert without 
inserting a missing one
   - MybatisPlusAlertRepository: implement replaceAlert
   - AlertService.acknowledgeAlert: use replaceAlert and return 404 when the 
alert no longer exists
   
   ## How was this patch verified
   
   - Code review: mirrors the replaceRule / replaceUser update-only patterns
   - `git diff --check` clean
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to