RongtongJin commented on code in PR #10843:
URL: https://github.com/apache/rocketmq/pull/10843#discussion_r3773439329
##########
controller/src/main/java/org/apache/rocketmq/controller/metrics/ControllerMetricsManager.java:
##########
@@ -303,7 +303,7 @@ public void init() {
if (StringUtils.isNotBlank(labels)) {
List<String> labelList =
Splitter.on(',').omitEmptyStrings().splitToList(labels);
for (String label : labelList) {
- String[] pair = label.split(":");
+ String[] pair = label.split(":", 2);
Review Comment:
Could we add matching regression coverage for the Controller and Proxy paths
as well? This PR changes the same colon-preserving parsing logic in Broker,
Controller, and Proxy, but only `BrokerMetricsManagerTest` currently covers a
value like `endpoint:https://collector:4317`. Since these are separate parser
implementations and Codecov flags the controller/proxy changed lines as
uncovered, small Controller/Proxy tests would make this fix safer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
