btlqql opened a new pull request, #2259:
URL: https://github.com/apache/rocketmq-dashboard/pull/2259

   ## Summary
   
   - reject null and blank notification-channel entries at the alert rule 
request boundary
   - trim and stable-deduplicate channels during DTO-to-domain conversion
   - defensively canonicalize channel lists before persistence for internal 
callers
   - normalize legacy comma-separated channel rows when loading alert rules
   
   ## Problem
   
   Alert rule channels were accepted as unconstrained string-list elements. A 
null element reached `String.join` and caused a server error, while blank, 
padded, and duplicate values were stored unchanged and could represent repeated 
notification destinations.
   
   ## Verification
   
   - 
`AlertRuleRequestDTOTest,MybatisPlusAlertRepositoryTest,AlertRuleControllerTest,AlertServiceTest`:
 72 tests passed
   - `mvn -DskipTests package`: passed
   - Maven Checkstyle: 0 violations
   - `git diff --check`
   
   Closes #2258
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to