lizhimins commented on PR #138:
URL: https://github.com/apache/rocketmq-flink/pull/138#issuecomment-5315542048
Pushed two follow-up commits:
1. `chore: apply spotless formatting` — the feature commit was written on a
JDK 21 toolchain, where the parent pom's `java17` profile disables spotless, so
google-java-format never validated it and the `Build (JDK 11)` check failed.
Both CI jobs are green now.
2. `fix: drop the empty protected_branches key from .asf.yaml` — unrelated
to this feature, but ASF Infra started rejecting the file:
```
when expecting a mapping
found a blank string
in "rocketmq-flink.git/.asf.yaml::github", line 13, column 1
```
`protected_branches:` has been present without a value since the file was
created in 2021, and YAML parses it as `null`. Because the parse fails, the
**whole `github` section is discarded** — the description, homepage, labels and
the `issues` / `wiki` feature flags never took effect. Removing the empty key
makes the section parse again; filling it in instead would change the
repository's actual branch-protection rules, which felt like a separate
decision. Happy to split this into its own PR if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
