tju-yxq commented on PR #2211: URL: https://github.com/apache/rocketmq-dashboard/pull/2211#issuecomment-5344729403
@lizhimins Rebased this branch onto the current `rocketmq-studio` trunk (`c0bdaab9`) and reworked the deletion flow to match the current instance model. The new head is `79fdc348`. The requested contracts are preserved: - the frontend sends the instance's unique string `name` for both normal and forced removal; - `InstanceController` resolves that boundary identifier with `resolveInstanceId`; - `InstanceService` and the repository use the numeric `Long` primary key; - both normal and forced deletion retain `removeDataSourceBindings(existing.getName())`, endpoint cleanup, the repository race check, and audit recording; - no direct String primary-key access was reintroduced. The preflight safety behavior is also retained: confirmed managed resources still block `force=true`; an unavailable preflight returns the stable 503 `errorCode` for a normal request; only the explicit second request can remove the local registration. The rebased implementation also checks Topic and Consumer Group inventories independently, so a confirmed resource from either inventory cannot be bypassed merely because the other inventory call failed. Local verification on the rebased head: - backend focused: 79 tests passed, Checkstyle 0 violations; - backend full: 1,479 tests passed, Checkstyle 0 violations; - frontend focused: 29 tests passed; - frontend full: 94 files / 628 tests passed; - frontend build passed; - frontend lint: 0 errors, with the existing `topic.tsx` hooks warning only; - `git diff --check` passed. I also refreshed the PR description with the rebased architecture, current diff size, and verification counts. GitHub CI has been triggered for `79fdc348`. Please re-review when convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
