lizhimins commented on PR #2397: URL: https://github.com/apache/rocketmq-dashboard/pull/2397#issuecomment-5367829020
Closing after re-review: the two ESLint regressions flagged in the previous review are still present (react-hooks/refs: ref write during render in useVisiblePolling.ts; react-hooks/set-state-in-effect in dlq.tsx). Baseline lint on both files is clean, so the errors are introduced by this PR. The dedup/useMemo parts look fine. Feel free to resubmit once the two lint errors are fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
