btlqql opened a new pull request, #2522:
URL: https://github.com/apache/rocketmq-dashboard/pull/2522

   ## What is the purpose of the change
   
   The CSV importer's name rules diverged from RocketMQ's own validators: topic 
names accepted `/` and `*` but rejected the `%` and `|` characters RocketMQ 
supports, consumer group names had to start with a letter, and neither kind had 
a length limit. The same name could be rejected by the import but accepted by 
the broker, or vice versa.
   
   ## Brief changelog
   
   - new shared `validateResourceName` used by both the topic and group CSV 
imports: the RocketMQ character set `[%|a-zA-Z0-9_-]`, with the Topic cap of 
127 and the group cap of 120
   - consumer group names may now start with a digit or symbol, matching 
RocketMQ
   - the inline Topic/Group create forms and the stale `topic.topicNameRule` 
translation now reference the same pattern and caps, so the UI and the importer 
agree
   - tests cover `%`, `|`, digit-leading groups, rejected `/` and `*`, and the 
127/128 and 120/121 length boundaries
   
   ## How was this patch verified
   
   - web: `resourceCsvImport.test.ts` 12/12; Topic/Consumer page tests green; 
full `vitest run` 642/642; `tsc -b` and `eslint` clean
   
   Fixes #2493
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to