RockteMQ-AI commented on code in PR #772:
URL: https://github.com/apache/rocketmq-spring/pull/772#discussion_r3844011915
##########
rocketmq-v5-client-spring-boot-samples/pom.xml:
##########
@@ -35,7 +35,9 @@
<module>rocketmq-v5-client-producer-simple-demo</module>
<module>rocketmq-v5-client-consumer-simple-demo</module>
<module>rocketmq-v5-client-consumer-push-simple-demo</module>
- </modules>
+
<module>rocketmq-v5-client-consume-simple-subscribe-muliti-topic-demo</module>
Review Comment:
This module is listed twice —
`rocketmq-v5-client-consume-simple-subscribe-muliti-topic-demo` appears on both
line 38 and 39. This will cause a Maven build error (`Malformed POM`). Please
remove the duplicate entry.
##########
rocketmq-v5-client-spring-boot-samples/pom.xml:
##########
@@ -35,7 +35,9 @@
<module>rocketmq-v5-client-producer-simple-demo</module>
<module>rocketmq-v5-client-consumer-simple-demo</module>
<module>rocketmq-v5-client-consumer-push-simple-demo</module>
- </modules>
+
<module>rocketmq-v5-client-consume-simple-subscribe-muliti-topic-demo</module>
Review Comment:
Typo in module name: `muliti` should be `multi`. Consider renaming the
directory and module to
`rocketmq-v5-client-consume-simple-subscribe-multi-topic-demo`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
