coder999o opened a new pull request, #2573: URL: https://github.com/apache/rocketmq-dashboard/pull/2573
## What is the purpose of the change The Settings page updates the URL query string when switching tabs, but it currently replaces all existing query parameters with only `tab`. This can drop unrelated navigation context, such as deep-link or focus parameters, when users move between Settings tabs. This change preserves existing query parameters and only updates the `tab` parameter. ## Brief changelog - Preserve unrelated Settings URL query parameters when switching tabs. - Added a regression test for tab switching with existing query parameters. ## Verifying this change - `npm test -- --run src/pages/settings/__tests__/SettingsPage.test.tsx src/pages/settings/__tests__/GeneralSettingsTab.test.tsx src/pages/settings/__tests__/AiAssistantTab.test.tsx src/pages/settings/__tests__/CloudCredentialTab.test.tsx src/pages/settings/__tests__/DataSourceTab.test.tsx` - `npx eslint src/pages/settings/index.tsx src/pages/settings/__tests__/SettingsPage.test.tsx --max-warnings=0` - `git diff --check` - `npm run build` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
