RockteMQ-AI commented on code in PR #2583:
URL:
https://github.com/apache/rocketmq-dashboard/pull/2583#discussion_r3853497769
##########
server/src/main/java/org/apache/rocketmq/studio/instance/acl/MybatisPlusAclRepository.java:
##########
@@ -103,6 +103,22 @@ public List<AclUserVO> findUsers() {
.collect(Collectors.toList());
}
+ @Override
+ public PageResult<AclUserVO> findUserPage(String keyword, int page, int
pageSize) {
+ QueryWrapper<RmqAclUser> query = new QueryWrapper<RmqAclUser>()
+ .and(StringUtils.hasText(keyword), w -> w
+ .like("username", keyword)
+ .or().like("access_key", keyword))
+ .orderByDesc("gmt_create")
+ .orderByDesc("id");
+ IPage<RmqAclUser> mapperPage = userMapper.selectPage(new Page<>(page,
pageSize), query);
+ List<AclUserVO> items = mapperPage.getRecords().stream()
Review Comment:
**[Info]** The `LIKE` keyword filter is consistent with `findRulePage`, but
note that MySQL `LIKE` is case-insensitive by default with `utf8mb4_general_ci`
collation. If the collation were ever changed to a binary/case-sensitive one,
this would silently break keyword matching. Consider adding a comment or using
`LOWER(username) LIKE LOWER(?)` for explicitness — though this is a very minor
nit and the current approach matches existing patterns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
