Aias00 opened a new pull request, #2965: URL: https://github.com/apache/rocketmq-dashboard/pull/2965
## Summary Consolidates the alert rule authoring correctness fixes from the existing focused PRs: - Replaces #2616 - Replaces #2606 - Replaces #2605 This keeps the fixes together because they all affect alert rule authoring/export correctness: - use a triggerable signed `delta()` expression for the bundled producer connection-drop rule in the generator, generated YAML, and frontend mock data - normalize legacy metric display labels and duration labels before create/update/test payload submission - share the Prometheus duration grammar between request validation and YAML export so composite durations such as `1h30m` round-trip correctly Closes #2614 Closes #2603 Closes #2604 ## Verification - `JAVA_HOME=$(/usr/libexec/java_home -v 21) mvn -Dtest=AlertRuleAssetServiceTest,AlertRuleRequestDTOTest,AlertServiceTest test` -> 87 tests passed - `npm test -- alertRuleAssetService.test.ts alerts.test.ts AlertsPage.test.tsx` -> 4 files / 43 tests passed - `npm run build` -> passed (`tsc -b && vite build`) - `JAVA_HOME=$(/usr/libexec/java_home -v 21) mvn -DskipTests package` -> passed - `python3 -m py_compile server/scripts/gen_alert_rule_yaml.py` -> passed - `git diff --check` -> passed - TypeScript diagnostics for `web/` -> 0 errors / 0 warnings ## Known baseline note `JAVA_HOME=$(/usr/libexec/java_home -v 21) mvn -Dtest='org.apache.rocketmq.studio.ops.alert.*Test' test` currently fails on the latest clean `origin/rocketmq-studio` as well: `AlertSchemaMigrationTest` tries to alter `rmq_instance_message.result_snapshot` when the table is absent. This PR does not modify that migration path; the targeted rule-authoring tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
