RockteMQ-AI commented on issue #3049: URL: https://github.com/apache/rocketmq-dashboard/issues/3049#issuecomment-5531448721
**Issue Evaluation** Category: `bug` | Status: **Confirmed** The reported inconsistency in metric normalization is a valid concern. The issue correctly identifies that: 1. AlertRuleController does not trim the metric before validation 2. Different code paths use inconsistent normalization (trimmed vs untrimmed) 3. This can lead to validation bypass and inconsistent behavior **Root Cause:** Missing normalization at the controller level, with inconsistent handling downstream. **Impact:** Security (validation bypass), correctness (inconsistent rule behavior) **Severity:** Medium **Recommendation:** Normalize (trim) the metric field at the controller level before any validation or storage. Ensure all downstream code paths use the normalized value consistently. An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
