RockteMQ-AI commented on issue #11153:
URL: https://github.com/apache/rocketmq/issues/11153#issuecomment-5632176444

   **Issue Evaluation**
   
   Category: `enhancement` | Status: **Evaluated**
   
   **Feasibility:** Feasible
   **Scope:** `NettyRemotingClient` — NameServer probe mechanism
   **Compatibility:** No breaking changes; internal refactoring only
   
   This is a well-reasoned optimization. The dedicated `scanExecutor` (4–10 
threads, queue of 32) for NameServer availability probes is redundant since 
Netty already handles asynchronous connection completion. Removing it 
simplifies the threading model and reduces resource overhead.
   
   **Key considerations for implementation:**
   - Connection-completion callbacks must correctly handle race conditions 
(late callbacks, removed addresses)
   - The `scanAvailableNameSrv` switch and probe interval must be preserved
   - Pending/failed connections must not be advertised as available
   
   This enhancement is suitable for a PR. The author has provided clear 
expected behavior.
   
   ---
   *Automated evaluation by github-manager*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to