lizhimins commented on PR #4169: URL: https://github.com/apache/rocketmq-dashboard/pull/4169#issuecomment-5679165238
Thanks for looking at the producer page's scope-change cleanup — the inconsistency you noticed is real: switching instance clears the connection results while switching topic does not. We can't take the change in this form, though. Clearing the state without also bumping `queryRequestIdRef` / clearing `queryInFlightRef` (as `handleInstanceChange` does) means a slow in-flight response still repopulates exactly what you just cleared, so the fix doesn't hold under the race it targets. The second test also rests on a mock that omits `topic` and `producerGroup`; the server populates both on every row, so the `connection.topic ?? selectedTopic` export fallback it asserts is never reached in production. A resubmission that invalidates the in-flight query, extracts one shared reset helper reused by both scope changes, and drops the export test would be a clear win — please do send it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
