lizhimins commented on PR #4118:
URL: 
https://github.com/apache/rocketmq-dashboard/pull/4118#issuecomment-5694489886

   Closing together with #4121, which changes the same collector for the same 
`-1` sentinel six minutes apart.
   
   We would rather land one trunk-side fix that covers every lag-derived sample 
than merge two partial patches: max-queue lag and per-topic backlog are what 
these two address, but `ApacheRocketMqBusinessMetricsCollector.java:123` still 
clamps `getDelaySeconds()` with `Math.max(0, ...)`, so after either patch the 
same consumer group would publish an explicit `CONSUMER_LAG_UNKNOWN` next to a 
fabricated zero delay. Your analysis of the sentinel path 
(`RocketMQMetadataProvider` -> `ConsumerLagResolver`) is correct and is what 
prompted the trunk-side item.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to