89799969 opened a new pull request, #5136:
URL: https://github.com/apache/rocketmq-dashboard/pull/5136

   ### Which Issue(s) This PR Fixes
   
   - Fixes #5127
   
   ### Brief Description
   
   LiteTopic session detail computed `consumedMessages` from the selected 
client's subscribed LiteTopics but obtained `pendingMessages` from a group-wide 
`getLiteGroupInfo` query (no LiteTopic filter), then added the two counters 
into `totalMessages`. A session therefore inherited other clients' backlog, 
which understated the consumption percentage and corrupted the 
`rmq.litetopic.session` tool output.
   
   This change computes pending and consumed totals from the same per-LiteTopic 
responses. An empty subscription now yields zero pending/total messages instead 
of inheriting the group-wide backlog. A missing per-topic body is surfaced as 
502 (same operational failure handling as before).
   
   ### How Did You Test This Change?
   
   `
   cd server && mvn -B -ntp -Dtest=RocketMQLiteTopicProviderTest test
   Tests run: 24, Failures: 0, Errors: 0, Skipped: 0
   `
   
   `
   cd server && mvn -B -ntp 
-Dtest='RocketMQLiteTopicProviderTest,LiteTopicSessionTest,LiteTopicServiceTest,LiteTopicControllerTest,LiteTopicSummaryTest,LiteTopicQuotaTest'
 test
   Tests run: 54, Failures: 0, Errors: 0, Skipped: 0
   `
   
   `
   cd server && mvn -B -ntp checkstyle:check
   You have 0 Checkstyle violations.
   `
   
   Two regression tests cover the mixed-scope case (two clients on different 
LiteTopics) and the empty-subscription case from the report.
   
   ### Checklist
   
   - [x] One coherent change; unrelated modifications are not bundled in
   - [x] Commit subject follows Conventional Commits (`feat:` / `fix:` / 
`refactor:` / `chore:` / `docs:` / `perf:`)
   - [x] Tests added or updated for non-trivial changes, test methods named 
`...Test`
   - [ ] New UI text has both Chinese and English entries under `web/src/i18n/` 
(N/A, backend only)
   - [x] Architecture constraints stay green (`mvn test` runs the ArchUnit 
checks)
   - [ ] New source files carry the ASF license header (N/A, no new files)
   - [ ] Documentation touched where behaviour changed (README / `docs/` / 
in-app help) (N/A)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to