X-LightYear commented on PR #4955: URL: https://github.com/apache/rocketmq-dashboard/pull/4955#issuecomment-5930725006
@lizhimins Thanks for the review. I rebuilt the branch on the latest `rocketmq-studio` base and addressed both requested changes: the paginated query now keeps the typed `notLikeRight` lambda predicates while escaping literal `%` and `_` values, and the PR description no longer claims semantic equivalence with the non-paginated `SystemTopicFilter`. The focused regression, `RocketMQMetadataProviderTest` (47 tests), `MetadataServiceTest` plus `ApacheInstanceProviderTest` (64 tests), Checkstyle, compile, JAR/repackage, and `git diff --check` pass. The final package gate is only blocked by the environment missing `python3` for the existing binary-license check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
