lizhimins commented on PR #5234: URL: https://github.com/apache/rocketmq-dashboard/pull/5234#issuecomment-6074066935
This pull request was closed by the stale bot on 2026-10-08 (seven days without activity), not by a maintainer decision - the review below is what we had queued for it. The two gaps you found are real - `InstanceSelect.tsx:47` and `:76` carry hardcoded Chinese, and all five call sites rely on those defaults. We reviewed them against the same three lines in #5403, which reuses the existing `common.selectInstance` key and pins the change with more cases; #5403 was merged into `rocketmq-studio` today, so the placeholder and the empty-list hint are localized now and this PR is superseded. There is nothing left to resubmit. For the record, what we would have asked for: reuse `common.selectInstance` (`translations.ts:3584`) instead of adding a second key for the same concept, wrap the 102-character `it(...)` line the way prettier wants it, and add a case pinning the Chinese side too (no `placeholder` prop, zh locale still shows 选择实例). Thanks for flagging it early - the fix landed, just through the other pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
