lizhimins commented on PR #5235: URL: https://github.com/apache/rocketmq-dashboard/pull/5235#issuecomment-6074067504
This pull request was closed by the stale bot on 2026-10-08 (seven days without activity), not by a maintainer decision - the review below is what we had queued for it. The five strings are real (audit.tsx:166, 225, 299, 310, 580) and the keys are new. Two things to fix: (1) both `message.error(t(...))` calls now sit inside effects whose dependency arrays you did not update — the records effect (deps at lines 172-182) and the summary effect (`[activeFilter, refreshKey]`, line 233). Trunk puts `t` in those arrays in 20+ places (e.g. MessageQueryHistoryDrawer.tsx:95); without it eslint's exhaustive-deps warns and a language switch leaves the closure holding the previous locale's `t`. (2) Only 2 of the 5 keys are asserted; the summary/cleanup/export toasts can be reverted to Chinese without reddening anything. Note also that #5327 fixes the same five lines with the same five key names, so only one of the two can land — please coordinate rather than both rebasing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
