chennaji9 opened a new pull request, #11326:
URL: https://github.com/apache/rocketmq/pull/11326
<!-- Please make sure the target branch is right. In most case, the target
branch should be `develop`. -->
### Which Issue(s) This PR Fixes
Fixes #11319
### Brief Description
`docs/en/Example_Filter.md` documents SQL92 filtering but never mentions
that the broker must run with `enablePropertyFilter=true` (default `false`,
`BrokerConfig.java:178`). Following the page against a stock broker, the
`MessageSelector.bySql` subscription is rejected at `consumer.start()` with
`SYSTEM_ERROR` ("The broker does not support consumer to filter message by
SQL92", `ClientManageProcessor.java:267`) and nothing on the page explains why.
The bundled example even carries the reminder in a code comment
(`SqlFilterConsumer.java:34`), the documentation does not.
Section 2 "Usage constraints" now states the prerequisite and shows the
`updateBrokerConfig` command; the interface snippet was also malformed
(`finalString` missing a space plus a non-breaking space inside the signature)
and is now valid Java.
### How Did You Test This Change?
Documentation-only change, verified statically at the PR base commit:
- `BrokerConfig.java:178`: `private boolean enablePropertyFilter = false;`
- `ClientManageProcessor.java:265-270`: SQL-type subscriptions get
`SYSTEM_ERROR` with the exact remark when the flag is off.
- The `mqadmin updateBrokerConfig -k enablePropertyFilter -v true`
invocation matches the documented broker config update mechanism.
- Snippet line is now plain ASCII (`grep`/`cat -A` check: no non-breaking
space, `final String`).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
