lizhimins commented on PR #5485: URL: https://github.com/apache/rocketmq-dashboard/pull/5485#issuecomment-6076047997
The defect is real (alerts.tsx:132-134) and the backend precedent you cite is accurate, but the new test file cannot compile: it imports AlertRule from '../../../api/alerts', and that module does not exist - AlertRule is exported from web/src/api/ops.ts (see alerts.tsx:44-50). Since web/tsconfig.app.json includes "src" and the build script is `tsc -b && vite build`, this turns the frontend build red. The new file is also the only one of your five new test files without the ASF license header (146 of 147 existing web test files carry it). One design point: the backend keeps full precision via BigDecimal.movePointRight(2), while Math.round(x*100*10)/10 caps at one decimal, so 0.1234 renders as 12.34% server-side and 12.3% here - please either match the backend or say explicitly that the cap is intentional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
