Wang1rrr opened a new pull request, #5882: URL: https://github.com/apache/rocketmq-dashboard/pull/5882
### Which Issue(s) This PR Fixes - Fixes #5776 ### Brief Description The frontend declares and sends `newAddr` for NameServer updates even though `UpdateNameServerDTO` accepts only `clusterId`, `addr`, and optional `version`. Align the API and service types with that DTO, explicitly serialize those fields, and remove the mock-only address rename. Regression tests cover the API, live service forwarding, and mock service with and without `version`. They also verify that an extra legacy `newAddr` is omitted from the request, mock addresses stay unchanged, and missing mock targets are rejected. This aligns the existing request contract. The backend still rejects NameServer updates as unsupported; enabling that operation requires separate backend work. ### How Did You Test This Change? From `web/`, on Windows with Node.js 24.14.0: - `npm test -- src/api/cluster.test.ts src/services/clusterService.test.ts`: 2 files, 22 tests passed. The new regression cases produced three failures before the implementation change. - `npm run lint`: passed, with 10 existing warnings in unrelated files. - Prettier and ESLint checks on the four changed files: passed. - `npm run build`: TypeScript passed, but Vite stopped at `[distribution-licenses] toggle-selection code or upstream license text does not match the verified source`. Reproduced the same failure on unmodified base commit `7e7aa344` in a separate worktree. The checked-in license blob matches the expected hash; this Windows checkout's CRLF copy does not. A successful production build is therefore not claimed. AI assistance: implemented with Codex and validated with the commands above. ### Checklist - [x] One coherent change; unrelated modifications are not bundled in - [x] Commit subject follows Conventional Commits - [x] Frontend regression tests added or updated; no Java test methods changed - [x] New UI text has both Chinese and English entries (N/A: no UI changes) - [ ] Architecture constraints stay green (`mvn test` not run; no backend changes) - [x] New source files carry the ASF license header (N/A: no new source files) - [x] Documentation touched where behaviour changed (request-contract correction explained above; no user-facing workflow changes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
